Include segment and element definitions as json files#4
Open
tdecaluwe wants to merge 1 commit intodevelopmentfrom
Open
Include segment and element definitions as json files#4tdecaluwe wants to merge 1 commit intodevelopmentfrom
tdecaluwe wants to merge 1 commit intodevelopmentfrom
Conversation
Owner
Author
|
This PR seems to decrease parsing speed by about 40%. Not merging yet. |
tdecaluwe
force-pushed
the
development
branch
5 times, most recently
from
9b581f3 to
8e4a97f
Compare
tdecaluwe
force-pushed
the
definitions
branch
from
f289b03 to
f86aa34
Compare
tdecaluwe
force-pushed
the
development
branch
2 times, most recently
from
cc1a7a7 to
11ea007
Compare
Open
tdecaluwe
force-pushed
the
development
branch
7 times, most recently
from
152c037 to
3863dca
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Load definitions from json files instead of using node includes.